DDF-4975 Remove Describe Endpoint from Catalog ThreatModel #4976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Describe Endpoint has been approved for deprecation. This PR removes those references from the Catalog.json ThreatModel. It also cleans up the ThreatModel by removing a now unused boundary, along with a now floating and disconnected
External Describe Service
actor value in the threat model.Who is reviewing it?
@austinsteffes
@ahoffer
@bakejeyner
Select relevant component teams:
@codice/security
Ask 2 committers to review/merge the PR and tag them here.
@brjeter
@stustison
@blen-desta
How should this be tested?
Use a service such as
OWASP Threat Dragon
to view the Catalog.json threat model. Verify it all looks good and there are no references to the Describe Endpoint. See screenshot for how it should look.What are the relevant tickets?
Fixes: #4975
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: