Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-4975 Remove Describe Endpoint from Catalog ThreatModel #4976

Merged
merged 1 commit into from Jun 20, 2019

Conversation

tyler30clemens
Copy link
Contributor

@tyler30clemens tyler30clemens commented Jun 17, 2019

What does this PR do?

The Describe Endpoint has been approved for deprecation. This PR removes those references from the Catalog.json ThreatModel. It also cleans up the ThreatModel by removing a now unused boundary, along with a now floating and disconnected External Describe Service actor value in the threat model.

Who is reviewing it?

@austinsteffes
@ahoffer
@bakejeyner

Select relevant component teams:

@codice/security

Ask 2 committers to review/merge the PR and tag them here.

@brjeter
@stustison
@blen-desta

How should this be tested?

Use a service such as OWASP Threat Dragon to view the Catalog.json threat model. Verify it all looks good and there are no references to the Describe Endpoint. See screenshot for how it should look.

What are the relevant tickets?

Fixes: #4975

Screenshots

image

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@brjeter
Copy link
Contributor

brjeter commented Jun 20, 2019

Hero successful ✅

@brjeter
Copy link
Contributor

brjeter commented Jun 20, 2019

Merging without CI as this change cannot affect the build.

@brjeter brjeter merged commit 973b666 into codice:master Jun 20, 2019
@jlcsmith jlcsmith added this to the 2.16.0 milestone Jun 24, 2019
troymohl pushed a commit to troymohl/ddf that referenced this pull request Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Describe Endpoint from Catalog.json ThreatModel
7 participants