Escape hyphen in already correctly working regex to fix warning #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtOfCode-
approved these changes
Jul 8, 2024
ArtOfCode-
deleted the
trichoplax/fix-development-unescaped-hyphen-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
rails sto serve a local development instance, a warning is given:Nothing is broken. Ruby understands that the third hyphen inside the square brackets is a literal hyphen, not a range indicator. The regex already matches exactly what it should. The only problem is the warning, causing clutter in the terminal.
This pull request escapes the hyphen in order to fix the warning. There is no change to functionality.