Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category tags #74

Merged
merged 9 commits into from
May 9, 2020
Merged

Category tags #74

merged 9 commits into from
May 9, 2020

Conversation

ArtOfCode-
Copy link
Member

In this PR:

  • Categories now have 'required tags' and 'topic tags'
  • Posts in a category with required tags must have at least one of those tags
  • No such requirement for topic tags
  • Both required and topic tags get special display: topic tags get an outline, required tags are filled.

@ArtOfCode- ArtOfCode- requested review from luap42 and cellio May 8, 2020 17:03
@ArtOfCode- ArtOfCode- added area: ruby Changes to server-side code area: html/css/js Changes to front-end code priority: high labels May 8, 2020
@cellio
Copy link
Member

cellio commented May 8, 2020

Your description sounds good to me. I've been trying to think of a better way to talk about required tags (to users), because it's really that you must include one member of this set. Any individual tag in that set isn't required; it's that you have to choose one from the group. If I could come up with better language I'd want to use that in the UI (defining them, instructions to include one, error if you don't). If anyone has any ideas please share. If not we can go with this; I just have this nagging feeling...

Can we set this up on the dev server to poke at?

@ArtOfCode-
Copy link
Member Author

Done. Dev server should be ready to poke.

Copy link
Member

@luap42 luap42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but CI is failing. :)

@ArtOfCode-
Copy link
Member Author

That's rubocop - I'm going to ignore it for now and fix it later on develop.

@ArtOfCode- ArtOfCode- merged commit 5ef8782 into develop May 9, 2020
@ArtOfCode- ArtOfCode- deleted the art/category_tags branch May 9, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: html/css/js Changes to front-end code area: ruby Changes to server-side code priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants