Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23 -- implement output message template format #29

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Sep 20, 2022

Inspired by pylint:
https://pylint.pycqa.org/en/latest/user_guide/usage/output.html#custom-message-formats

Todo if accepted:

  • tests
  • documentation of all template options

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request introduces 1 alert when merging 1b32029 into 39dd830 - view on LGTM.com

new alerts:

  • 1 for Unused import

@amureki amureki marked this pull request as ready for review September 22, 2022 14:49
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4f88484) compared to base (638f534).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          125       123    -2     
=========================================
- Hits           125       123    -2     
Impacted Files Coverage Δ
relint/__main__.py 100.00% <100.00%> (ø)
relint/parse.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe
Copy link
Owner

@amureki would you care to review this? I'd like to release this in the next major version (v2).

@amureki amureki force-pushed the msg-template branch 3 times, most recently from 416f75b to 4c05908 Compare October 3, 2022 12:21
@codingjoe
Copy link
Owner

@amureki almost 😉

@amureki
Copy link
Collaborator Author

amureki commented Oct 3, 2022

@amureki almost 😉

I'll finish it later today, haha 😁

@amureki
Copy link
Collaborator Author

amureki commented Oct 3, 2022

@codingjoe not sure I follow the test rule here:

- name: Not Unicode
pattern: '[tT][oO][dD][oO]'
filePattern: .*
error: false

it mentions unicode, but rule itself copies pattern from "No ToDo" rule above...

@codingjoe
Copy link
Owner

@codingjoe not sure I follow the test rule here:

- name: Not Unicode
pattern: '[tT][oO][dD][oO]'
filePattern: .*
error: false

it mentions unicode, but rule itself copies pattern from "No ToDo" rule above...

My bad, you can just remove the pattern. It's not needed.

relint/__main__.py Outdated Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Johannes Maron <johannes@maron.family>
@amureki amureki requested a review from codingjoe October 4, 2022 07:34
Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codingjoe codingjoe merged commit 0dc9dc3 into codingjoe:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants