-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #23 -- implement output message template format #29
Conversation
This pull request introduces 1 alert when merging 1b32029 into 39dd830 - view on LGTM.com new alerts:
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 125 123 -2
=========================================
- Hits 125 123 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@amureki would you care to review this? I'd like to release this in the next major version (v2). |
416f75b
to
4c05908
Compare
@amureki almost 😉 |
I'll finish it later today, haha 😁 |
@codingjoe not sure I follow the test rule here: relint/tests/fixtures/.relint.yml Lines 7 to 10 in 638f534
it mentions unicode, but rule itself copies pattern from "No ToDo" rule above... |
My bad, you can just remove the pattern. It's not needed. |
Co-authored-by: Johannes Maron <johannes@maron.family>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Inspired by pylint:
https://pylint.pycqa.org/en/latest/user_guide/usage/output.html#custom-message-formats
Todo if accepted: