-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYN currency support not stable #635
Comments
This currency isn't supported by Java until the latests releases (see this OpenJDK bug report). It seems it's possible to add new currencies, but only from Java 7 onwards. One possibility would be to use Joda-Money. It supports BYN and can be easily extended to support any new currency. It's not API stable yet, so we should check other alternatives first. We should also avoid crashes in these situations. By the way, Joda-Money also provides a Money class which we could evaluate to replace ours. |
This is can (and probably should) be fixable. We now use our own commodities and if I recall correctly, @rivaldi8 you once did some cleanup to use only our Commodities instead of java Currency. Maybe there is some place where Currency is still used. If we change it to commodity, this issue should be fixed. BYN was added to the commodities a while back I think, although I don't recall if only to new installations or also for existing ones. The latter case can easily be fixed with a database migration. |
About Joda-Money, well, it is still evolving. If they get to a 1.0 at some point we can evaluate it. Although I'm beginning to have increasing inertia to new libraries as we have quite a few already. Build time keeps going up and the apk is starting to hit the 65k method limit in the develop branch. |
Ok, I was convinced that |
@codinguser I have v2.1.5 and it seems that BYN is supported now (at least for importing data from gnucash for desktop) |
@codinguser The issues reported here seem to be fixed now. There are still a few uses of Currency which may make the application crash, though. I hope to finish the migration to Commodity shortly. |
Ok!
…On Wed 12. Apr 2017 at 17:59, Àlex Magaz Graça ***@***.***> wrote:
@codinguser <https://github.com/codinguser> The issues reported here seem
to be fixed now. There are still a few uses of Currency which may make the
application crash, though. I hope to finish the migration to Commodity
shortly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#635 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQ420VCXBAvETffNlhj2pvPRwCDqB6Kks5rvPT3gaJpZM4LZa1F>
.
|
I've just finished the migration to Commodity. |
Cases in which it fails
Expected behaviour in each case
Actual behaviour in each case
Software specifications
The text was updated successfully, but these errors were encountered: