Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested Git repositories #5

Closed
zxqfl opened this issue Nov 8, 2018 · 2 comments
Closed

Support nested Git repositories #5

zxqfl opened this issue Nov 8, 2018 · 2 comments

Comments

@zxqfl
Copy link
Contributor

zxqfl commented Nov 8, 2018

root
|
|-- subproj1
|
|-- subproj2
    |
    |-- subsubproj1
    |
    |-- subsubproj2

Currently TabNine will stop at the first .git it finds, but it should continue to try to find a .tabnine_root.

@zxqfl zxqfl closed this as completed in bca744f Nov 21, 2018
zxqfl added a commit that referenced this issue Nov 21, 2018
Closes #5
Closes #7
Closes #8
Closes #10
Closes #11
Closes #14
Closes #15
@trishume
Copy link

Watch out, some people have their home directory as a git directory for dotfiles purposes. I think this is a bad idea but in nevertheless happens and might be worth a special case to avoid.

@zxqfl
Copy link
Contributor Author

zxqfl commented Nov 22, 2018

This should be fine -- we still stop at the first .git, we only keep looking for a .tabnine_root. (So users with nested Git repos need to put a tabnine_root in the parent repo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants