Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabNine should not index files in .git #8

Closed
zxqfl opened this issue Nov 12, 2018 · 6 comments
Closed

TabNine should not index files in .git #8

zxqfl opened this issue Nov 12, 2018 · 6 comments

Comments

@zxqfl
Copy link
Contributor

zxqfl commented Nov 12, 2018

No description provided.

@sergei-dyshel
Copy link

Ultimately it would be nice to have some ignore file (e.g. .tabnine.ignore) and combine it with .gitignore, like Rigpgrep does.

@zxqfl
Copy link
Contributor Author

zxqfl commented Nov 12, 2018

This is actually already implemented, you can create an .ignore file.

@sergei-dyshel
Copy link

I would rather prefer to have it different name, since .ignore is used by grep-like tools (ack, ripgrep etc.). I think TabNine-specific ignore file may ignore stuff which still need to be grepped...

@sergei-dyshel
Copy link

configurable name would be the best...

@BurntSushi
Copy link

BurntSushi commented Nov 19, 2018

The .ignore file is supposed to be somewhat generic. ripgrep also supports a .rgignore file, and if TabNine is using the ignore crate, then it can add its own .tabnine.ignore file as well. So the idea is that you put universal ignore rules in .ignore, but application specific rules in .rgignore, .fdignore, .tabnine.ignore, etc.

@zxqfl
Copy link
Contributor Author

zxqfl commented Nov 21, 2018

Added .tabnineignore. @BurntSushi TabNine does use ignore, as well as regex -- thanks for the great libraries!

@zxqfl zxqfl closed this as completed in bca744f Nov 21, 2018
zxqfl added a commit that referenced this issue Nov 21, 2018
Closes #5
Closes #7
Closes #8
Closes #10
Closes #11
Closes #14
Closes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants