Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): downgrade source-map v0.7.0...0.5.6 #309

Merged
merged 1 commit into from
Feb 26, 2018
Merged

fix(package): downgrade source-map v0.7.0...0.5.6 #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"async": "^2.0.0",
"loader-utils": "^1.0.0",
"lodash": "^4.0.0",
"source-map": "^0.7.0",
"source-map": "^0.5.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ^0.6.0 is ok here, according to the CHANGELOG support for node < v8.0.0 was drop in v0.7.0

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md

Breaking change: Drop support for Node < 8. If you want to support older versions of node, please use v0.6 or below.

But the CHANGELOG sadly misses notes about the 0.6.0 release 😞, so maybe 0.5.6 is 'safer'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured since the project was previously on ^0.5.6, it was safer to just revert this version bump. But I would be happy to upgrade ^0.6.0 instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's better leave it :)

"webpack-dev-middleware": "^1.12.0"
},
"devDependencies": {
Expand Down