Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backtrack user #2

Merged
merged 10 commits into from Jun 17, 2020
Merged

Feature/backtrack user #2

merged 10 commits into from Jun 17, 2020

Conversation

godgunman
Copy link
Member

No description provided.

@MrOrz
Copy link
Member

MrOrz commented Jun 17, 2020 •
edited

我想確認一下，這個 PR 主要是把原本的 parser 改寫成可以 require 到其他 script 的版本，尚未包含生成 userArticleLink 的邏輯這樣嗎

畢竟 PR 沒有 description ._.

@godgunman
Copy link
Member Author

阿是的，生成 userArticleLink 的 PR 預計長在這 cofacts/rumors-line-bot#201

MrOrz
MrOrz approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! sequential option design is interesting.

@MrOrz MrOrz merged commit 5446ec8 into master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@godgunman @MrOrz