Add tesseract-ocr to process image messages #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Extract message_process statements to `processText` function 2. Save and process image files in tmp_image_process dir
1. [initState] Don't reply article found prefix when `messageType` is not text 2. [askingArticleSource] Reorder statements, handle foundArticle first, able-to-send-to-database second, then others(self-input and image)
Pull Request Test Coverage Report for Build 582
💛 - Coveralls |
|
How accurate is it now? |
update above |
MrOrz
reviewed
Dec 4, 2019
src/handlers/initState.js
Outdated
| @@ -146,9 +150,16 @@ export default async function initState(params) { | |||
| }, | |||
| templateMessage, | |||
| ]; | |||
| console.log(JSON.stringify(event)); | |||
There was a problem hiding this comment.
please remove this console.log, thanks
LucienLee
reviewed
Dec 4, 2019
src/handlers/initState.js
Outdated
| @@ -133,11 +135,13 @@ export default async function initState(params) { | |||
| }, | |||
| }; | |||
|
|
|||
| replies = [ | |||
| var prefixTextArticleFound = [ | |||
LucienLee
reviewed
Dec 4, 2019
src/handlers/initState.js
Outdated
| { | ||
| type: 'text', | ||
| text: `🔍 ${t`There are some messages that looks similar to "${articleSummary}" you have sent to me.`}`, | ||
| }, | ||
| ]; | ||
| var textArticleFound = [ |
LucienLee
approved these changes
Dec 4, 2019
LucienLee
approved these changes
Dec 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. Add tesseract-ocr to process image messages
processTextfunction.b. Update reply messages for image input
messageTypeis not text.messageTypeis not text and is able to send article to database.update : 2019/12/04 20:34
tesseract-ocr-4.1.0+tessdata-4.0.0 (my local machine)
"White word" tesseract can't recognize well.
tesseract-ocr-4.0.0+tessdata-4.0.0 (Heroku)
But on the Heroku the result is not good as my local machine, maybe I should update Buildpack's tesseract binary version to 4.1.0.
