New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIFF <> GraphQL server communication #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 738
💛 - Coveralls |
MrOrz
moved this from In progress
to Review in progress
in [Cofacts Next] 告知 Chatbot 使用者新回應
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
src/liff/pages/{Source|Reason|PositiveFeedback|NegativeFeedback}.svelte
page stubssrc/liff/index.html
andsrc/liff/App.svelte
gql
in LIFF that sends authorization header, andgraphql
server that verifies the authorization headerissuedAt
withdata.sessionId
in GraphQL context API.Screenshot
LIFF button opened previously
If LIFF button is pressed before, pressing it again could be pretty fast:
https://drive.google.com/file/d/1hpv2Z1vjWItUBSmUmV2SXryjbKj5-MVQ/view?usp=sharing
The screencast shows:
App.svelte
routing mechanism worksgql
in LIFF works with GraphQL context &@auth
mechanismCache-control: max-age
worksFresh LIFF button
For a new LIFF button, LIFF HTML is fetched from server, which makes the LIFF redirection obvious
https://drive.google.com/file/d/1i0pl1iqHaMVNTJR6cm8_mpf6SHK5A7qw/view?usp=sharing
The screencast shows:
Abort LIFF for buttons in previous search sessions
When user inputs a new rumor, it is considered as "creating a new search session". LIFF opened with previous sessions are aborted.
https://drive.google.com/file/d/1iUmdNL4os9yyTPHOqyLUjWOl2Ewb7HMR/view?usp=sharing