Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIFF asking source #179

Merged
merged 1 commit into from May 13, 2020
Merged

LIFF asking source #179

merged 1 commit into from May 13, 2020

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Apr 26, 2020

Implements the LIFF asking user about message source.

Screenshots

image

Pressing invalid sources

https://drive.google.com/open?id=1i3gOOxN6bAfl0AeOsEAI2zvIO0-az55t

  • Closes LIFF
  • Sends message to chatbot

Pressing valid sources

https://drive.google.com/open?id=1i5TJXLMRYInPHxePP18aE2-vZFmUADOZ

  • Page switch to reason LIFF
  • Sends message to chatbot; article submitted to database, and source recorded under the hood

@MrOrz MrOrz self-assigned this Apr 26, 2020
@MrOrz MrOrz added this to In progress in [Cofacts Next] 告知 Chatbot 使用者新回應 via automation Apr 26, 2020
@coveralls
Copy link

coveralls commented Apr 26, 2020 •
edited

Pull Request Test Coverage Report for Build 740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.636%
Totals Coverage Status
Change from base Build 737: 0.0%
Covered Lines: 302
Relevant Lines: 303
💛 - Coveralls

[Cofacts Next] 告知 Chatbot 使用者新回應 automation moved this from In progress to Reviewer approved Apr 27, 2020
@MrOrz MrOrz changed the base branch from liff-comm to dev May 13, 2020 12:01
@MrOrz MrOrz merged commit abbacd3 into dev May 13, 2020
[Cofacts Next] 告知 Chatbot 使用者新回應 automation moved this from Reviewer approved to Done May 13, 2020
@MrOrz MrOrz deleted the liff-source branch June 12, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@godgunman godgunman Awaiting requested review from godgunman

@LucienLee LucienLee Awaiting requested review from LucienLee

@changhc changhc Awaiting requested review from changhc

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
No open projects
[Cofacts Next] 告知 Chatbot 使用者新回應
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrOrz @coveralls @bil4444