Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIFF asking reason #180

Merged
merged 2 commits into from May 13, 2020
Merged

LIFF asking reason #180

merged 2 commits into from May 13, 2020

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Apr 27, 2020 •
edited

Implements previous LIFF reason logic using svelte.

Screenshots

confirms when length is not sufficient

https://drive.google.com/open?id=1il5LsMauQHRr3UTMlx5R3qRUFVjrku5g

blocks reasons that is totally identical to searched text

https://drive.google.com/open?id=1io-nzIcnC-IS2_7uLokBHSzsH815fUmS

confirm button changes color once length reached threshold

Current threshold is 40 characters, the same as previous implementation.
https://drive.google.com/open?id=1ijwzhkWetWkz-JlxB2SGq42R9GMkpmBi

@MrOrz MrOrz self-assigned this Apr 27, 2020
@coveralls
Copy link

coveralls commented Apr 27, 2020 •
edited

Pull Request Test Coverage Report for Build 742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.636%
Totals Coverage Status
Change from base Build 739: 0.0%
Covered Lines: 302
Relevant Lines: 303
💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review April 27, 2020 06:21
@MrOrz MrOrz changed the base branch from liff-source to dev May 13, 2020 12:02
@MrOrz MrOrz merged commit 2611f58 into dev May 13, 2020
@MrOrz MrOrz deleted the liff-reason branch June 16, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@godgunman godgunman Awaiting requested review from godgunman

@LucienLee LucienLee Awaiting requested review from LucienLee

@changhc changhc Awaiting requested review from changhc

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrOrz @coveralls @bil4444 @johnson-liang