Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test for src/liff/lib #196

Merged
merged 7 commits into from Jun 16, 2020
Merged

Unit test for src/liff/lib #196

merged 7 commits into from Jun 16, 2020

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jun 12, 2020

This PR adds unit tests for things in src/liff/lib, including:

  • isDuringLiffRedirect const
  • gql
  • assertInClient
  • assertSameSearchSession

@MrOrz MrOrz requested review from LucienLee and nonumpa June 12, 2020 17:00
@MrOrz MrOrz self-assigned this Jun 12, 2020
@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited

Pull Request Test Coverage Report for Build 876

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 98.39%
Totals Coverage Status
Change from base Build 868: -0.1%
Covered Lines: 422
Relevant Lines: 423
💛 - Coveralls

nonumpa
nonumpa approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrOrz MrOrz merged commit 42b1955 into dev Jun 16, 2020
@MrOrz MrOrz deleted the liff-lib-test branch June 16, 2020 05:09
@MrOrz MrOrz mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonumpa nonumpa nonumpa approved these changes

@LucienLee LucienLee Awaiting requested review from LucienLee

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrOrz @coveralls @nonumpa @johnson-liang