Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIFF] Fix UserSetting page ux that shows switch ui after data loaded #230

Merged
merged 1 commit into from Oct 29, 2020
Merged

[LIFF] Fix UserSetting page ux that shows switch ui after data loaded #230

merged 1 commit into from Oct 29, 2020

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Oct 26, 2020

Before:

After:

@nonumpa nonumpa requested a review from MrOrz October 26, 2020 07:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.968%
Totals Coverage Status
Change from base Build 1166: 0.0%
Covered Lines: 711
Relevant Lines: 827
💛 - Coveralls

MrOrz
MrOrz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! Reducing the button flicker looks much better!

@MrOrz MrOrz merged commit 223b270 into dev Oct 29, 2020
@MrOrz MrOrz deleted the fix/liff-setting-ux branch October 29, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nonumpa @coveralls @MrOrz