Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common components in LIFF #267

Merged
merged 15 commits into from Jun 29, 2021
Merged

Common components in LIFF #267

merged 15 commits into from Jun 29, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jun 19, 2021 •
edited

  • Remove global material design styles, which is not currently in use
  • Add Cofacts palette as CSS custom properties
  • Implement Button, TextArea and Switch
  • Add SVG Icons

Button

image
image

TextArea

(Yellow background not included in component, just for demo purpose)
image
image

Switch

switch
image

Icons

image
image

@MrOrz MrOrz marked this pull request as draft June 19, 2021 18:36
@MrOrz MrOrz self-assigned this Jun 19, 2021
@coveralls
Copy link

coveralls commented Jun 20, 2021 •
edited

Pull Request Test Coverage Report for Build 963486247

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.107%
Totals Coverage Status
Change from base Build 961782184: 0.0%
Covered Lines: 950
Relevant Lines: 1076
💛 - Coveralls

Base automatically changed from storybook to master June 22, 2021 18:56
@MrOrz MrOrz marked this pull request as ready for review June 23, 2021 07:52
@MrOrz MrOrz changed the title [WIP] Common components in LIFF Common components in LIFF Jun 23, 2021
@MrOrz
Copy link
Member Author

MrOrz commented Jun 29, 2021

Merge as PR has been out for 10 days

@MrOrz MrOrz merged commit ab48018 into master Jun 29, 2021
@MrOrz MrOrz deleted the common-components branch June 29, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@LucienLee LucienLee Awaiting requested review from LucienLee

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrOrz @coveralls @bil4444