New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/220 highlight null #269
Conversation
Pull Request Test Coverage Report for Build 955810650
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a million on the fix!
I wonder why package-lock.json would change in the PR, it seems that we did not change package.json
. Suggest exclude that from the PR and we are good to go!
https://github.blog/2021-02-02-npm-7-is-now-generally-available/#changes-to-the-lockfile npm changes its lockfile version after v7. If you use npm@7 to run |
a1c9965
to
89082cf
Compare
I just switched to master from a old branch and ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's ship it
Seems that we |
Sorry, my |
Changes
We still need to fix this issue in rumors-api
2. Updatepackage-lock.json
,lockfileVersion
: 1 -> 2Snapshot