Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/220 highlight null #269

Merged
merged 2 commits into from Jun 21, 2021
Merged

Issue/220 highlight null #269

merged 2 commits into from Jun 21, 2021

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Jun 21, 2021

Changes

  1. Fixes TypeError: Cannot read property 'split' of undefined #220, return original text if highlight text and hyperlinks are null
    We still need to fix this issue in rumors-api

2. Update package-lock.json, lockfileVersion: 1 -> 2

Snapshot
截圖 2021-06-21 上午11 22 10

@nonumpa nonumpa requested a review from MrOrz June 21, 2021 03:19
@coveralls
Copy link

coveralls commented Jun 21, 2021

Pull Request Test Coverage Report for Build 955810650

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 87.107%

Totals Coverage Status
Change from base Build 943499647: 0.09%
Covered Lines: 950
Relevant Lines: 1076

💛 - Coveralls

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million on the fix!

I wonder why package-lock.json would change in the PR, it seems that we did not change package.json. Suggest exclude that from the PR and we are good to go!

@tw0517tw
Copy link

https://github.blog/2021-02-02-npm-7-is-now-generally-available/#changes-to-the-lockfile

npm changes its lockfile version after v7. If you use npm@7 to run npm install you'll get a version change in your lockfile unless you run npm install --no-save.

@nonumpa
Copy link
Member Author

nonumpa commented Jun 21, 2021

Thanks a million on the fix!

I wonder why package-lock.json would change in the PR, it seems that we did not change package.json. Suggest exclude that from the PR and we are good to go!

I just switched to master from a old branch and ran npm i. I thought it would have dependency error if I don't commit the change. (seems not)

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's ship it :shipit:

@MrOrz MrOrz merged commit 2560574 into master Jun 21, 2021
@MrOrz MrOrz deleted the issue/220-highlight-null branch June 21, 2021 05:16
@MrOrz
Copy link
Member

MrOrz commented Jun 21, 2021

Seems that we are also changing lockVersion to 2 in this PR. After its merge we should have a stable lockfile. have already changed lockfileVersion to 2 in a previously merged PR.

@nonumpa
Copy link
Member Author

nonumpa commented Jun 21, 2021

Sorry, my lockfileVersion was from 2 to 1. It seems that running npm install through npm@6 (my local version) will change lockfileVersion back to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'split' of undefined
4 participants