Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional flex alt text #308

Merged
merged 3 commits into from Apr 26, 2022
Merged

Remove additional flex alt text #308

merged 3 commits into from Apr 26, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Apr 24, 2022

const FLEX_MESSAGE_ALT_TEXT in handlers/util asks the user to proceed action on their mobile phone, if their device does not support flex messages.

At this point of time, all devices, including desktop, supports flex messages. The only chance the user can see the alt text is probably the short quote in the chatroom list, which only displays the first few letters.
圖片

When implementing new submission flow, I removed FLEX_MESSAGE_ALT_TEXT and updates each of its occurrences. This is submitted as a separate PR (this PR) in order to make the main PR more focused.

@MrOrz MrOrz requested a review from nonumpa April 24, 2022 17:30
@MrOrz MrOrz self-assigned this Apr 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2216308322

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 87.343%

Totals Coverage Status
Change from base Build 2197145743: -0.008%
Covered Lines: 982
Relevant Lines: 1109

💛 - Coveralls

Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from update-translation to master April 26, 2022 03:06
@MrOrz MrOrz merged commit 901075c into master Apr 26, 2022
@MrOrz MrOrz deleted the remove-flex-alt branch April 26, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants