Fix issue choosing reply button expire #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions (handleInput, handlePostback and processImage)
Remove handlePostback mock, use choosingArticle and choosingReply api fixture instead
MrOrz
reviewed
Sep 20, 2022
| @@ -70,10 +70,17 @@ export default async function({ data = {} }, event, userId) { | |||
|
|
|||
| // choose for user | |||
| event = { | |||
| type: 'postback', | |||
| type: 'server_choose', | |||
There was a problem hiding this comment.
Question: what would happen if we just use 'postback' here?
There was a problem hiding this comment.
No functional difference.
I use server_choose just to sperate two different flow : "user choose" and "server choose for user".
|
This can be reproduced on local machine using |
Even though the function under test does not import MongoDB client, its dependency may do. Therefore we just close DB connection for each test suite by adding DB closing logic in setup-jest.
Pull Request Test Coverage Report for Build 3095429439
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #323
Directly call the specific handler function when choosing article/reply for user