Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue, cannot choose "no such message" when searching for images #334

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Fix issue, cannot choose "no such message" when searching for images #334

merged 2 commits into from
Oct 6, 2022

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Oct 2, 2022 •
edited
Loading

Fix #326

Snapshots

image hit but select not found

image not found

@nonumpa nonumpa requested a review from MrOrz October 2, 2022 15:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3169040853

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.594%
Totals Coverage Status
Change from base Build 3149053556: 0.05%
Covered Lines: 933
Relevant Lines: 999
💛 - Coveralls

MrOrz
MrOrz approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's ship it :shipit:

@MrOrz MrOrz merged commit 89f2871 into master Oct 6, 2022
@MrOrz MrOrz deleted the issue/326-imagenotfound-button branch October 6, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot choose "no such message" when searching for images
3 participants
@nonumpa @coveralls @MrOrz