Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google cloud's Application Default Credentials #350

Merged
merged 8 commits into from
May 3, 2023
Merged

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Apr 27, 2023

When deploying this, we should do the following:

  1. Create a new service account (and its credential) representing Cofacts LINE bot (both staging and production) as a whole
    • Ensure it has permission to access Dialogflow (see README for the required permission)
  2. Setup GOOGLE_APPLICATION_CREDENTIALS for rumors-line-bot (Changes to rumors-deploy: Update line bot service account's keys rumors-deploy#23)
  3. Update rumors-line-bot image and test if Dialogflow integration still work
  4. Cleanup old environment variables

After we repeat the above process for both staging and production environment, we can cleanup old service account that is specific to Dialogflow only.

…ng multiple env vars

- This is the first step to reuse service accounts with BigQuery in the future
Replace env with credential detection mock
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Pull Request Test Coverage Report for Build 4822667690

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.558%

Totals Coverage Status
Change from base Build 4822470920: -0.02%
Covered Lines: 962
Relevant Lines: 1030

💛 - Coveralls

@MrOrz MrOrz self-assigned this Apr 27, 2023
@MrOrz MrOrz marked this pull request as ready for review April 27, 2023 17:21
- Without this fix, import to ts file in in `webhook/handlers/initState` will not be transformed into relative path by module-resolver
@MrOrz MrOrz requested a review from nonumpa May 3, 2023 12:21
@MrOrz MrOrz merged commit 194fb8a into master May 3, 2023
5 checks passed
@MrOrz MrOrz deleted the google-auth branch May 3, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant