Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching text will highlight transcripts in article list #359

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

johnson-liang
Copy link
Contributor

@johnson-liang johnson-liang commented Aug 15, 2023

Implements part of https://g0v.hackmd.io/0tPABSZ6SRKswBYqAc1vZw#AI (when searching text)

  • Transcripts are in text field and may allow media content enter search result list
  • We tell the user that the snippet is from a transcript

Refactor: GqlResponse generic type helps typing test fixtures

image

@coveralls
Copy link

coveralls commented Aug 16, 2023

Pull Request Test Coverage Report for Build 5887396606

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.824%

Totals Coverage Status
Change from base Build 5887390815: 0.1%
Covered Lines: 991
Relevant Lines: 1063

💛 - Coveralls

@johnson-liang johnson-liang marked this pull request as ready for review August 17, 2023 05:05
@johnson-liang johnson-liang self-assigned this Aug 17, 2023
@johnson-liang johnson-liang merged commit 355f2f6 into master Aug 17, 2023
7 checks passed
@johnson-liang johnson-liang deleted the media-similarity branch August 17, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants