Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] simplify text handlers as well #371

Merged
merged 5 commits into from
Nov 22, 2023
Merged

[2] simplify text handlers as well #371

merged 5 commits into from
Nov 22, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Nov 5, 2023

  • Simplies handleInput and initState handler to handle just text events
    • handleInput is in charge of creating new (text) search session
    • initState takes input text from search session, no need to compose an event for it, greatly simplifies stuff
  • Removes ChatbotEvent completely, as postback and text event handlers has their own events
    • This also removes the mock server_choose events and type for event.input, as we no longer need those.

@MrOrz MrOrz changed the base branch from id-in-context to revamp-postback-handlers November 12, 2023 10:33
Copy link
Member Author

MrOrz commented Nov 12, 2023

@MrOrz MrOrz force-pushed the refactor-text-msg branch 2 times, most recently from 3554eb3 to 9c83fb4 Compare November 12, 2023 16:49
@MrOrz MrOrz changed the title refacto(webhook): simplify text handlers as well refactor(webhook): simplify text handlers as well Nov 12, 2023
@coveralls
Copy link

coveralls commented Nov 12, 2023

Pull Request Test Coverage Report for Build 6842018647

  • 15 of 17 (88.24%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 89.64%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/webhook/index.ts 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/webhook/handlers/defaultState.ts 2 0.0%
Totals Coverage Status
Change from base Build 6841960699: -0.1%
Covered Lines: 965
Relevant Lines: 1039

💛 - Coveralls

@MrOrz MrOrz changed the title refactor(webhook): simplify text handlers as well [2] simplify text handlers as well Nov 12, 2023
@MrOrz MrOrz marked this pull request as ready for review November 14, 2023 18:49
@MrOrz MrOrz self-assigned this Nov 14, 2023
This was referenced Nov 19, 2023
Copy link
Member Author

MrOrz commented Nov 22, 2023

Merge activity

  • Nov 22, 8:01 AM: @MrOrz started a stack merge that includes this pull request via Graphite.
  • Nov 22, 8:01 AM: @MrOrz merged this pull request with Graphite.

Base automatically changed from revamp-postback-handlers to master November 22, 2023 13:01
@MrOrz MrOrz merged commit 90358bc into master Nov 22, 2023
4 of 7 checks passed
@MrOrz MrOrz deleted the refactor-text-msg branch November 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants