Feature/refine dev env #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
requested changes
Nov 25, 2017
package.json
Outdated
| "lint": "eslint --fix .", | ||
| "lint:check": "eslint ." | ||
| "lint": "./node_modules/eslint/bin/eslint.js --fix .", | ||
| "lint:check": "./node_modules/eslint/bin/eslint.js ." |
There was a problem hiding this comment.
eslint 不會 copy 到 node_modules/.bin 嗎？
There was a problem hiding this comment.
不會吧？你如果沒有用 npm install -g eslint，根本不能直接跑 eslint 吧？
There was a problem hiding this comment.
package-lock.json
Outdated
| }, | ||
| "ecc-jsbn": { | ||
| "version": "0.1.1", | ||
| " |
There was a problem hiding this comment.
prettier 升級到 1.7.0 應該會有超多 syntax fix 吧 @@
應該一併 include 進來，不然之後所有 test 都會 fail
godgunman
force-pushed
the
feature/refine-dev-env
branch
from
3a68961
to
815318a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.