feat(ArticleStatusFilter): add "has useful replies" filter

cofacts · Mar 17, 2023 · d1531d5 · d1531d5
1 parent 66d7bb7
commit d1531d5
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 28 deletions.
diff --git a/components/ListPageControls/ArticleStatusFilter.tsx b/components/ListPageControls/ArticleStatusFilter.tsx
@@ -21,6 +21,7 @@ const OPTIONS = [
   { value: FILTERS.NO_REPLY, label: t`Zero replies` },
   { value: FILTERS.REPLIED_MANY_TIMES, label: t`Replied many times` },
   { value: FILTERS.NO_USEFUL_REPLY_YET, label: t`No useful reply yet` },
+  { value: FILTERS.HAS_USEFUL_REPLY, label: t`Has useful replies` },
   { value: FILTERS.REPLIED_BY_ME, label: t`Replied by me` },
 ];
 
@@ -32,6 +33,7 @@ const MUTUALLY_EXCLUSIVE_FILTERS: ReadonlyArray<
   // Sets of filters that are mutually exclusive (cannot be selected together)
   [FILTERS.ASKED_ONCE, FILTERS.ASKED_MANY_TIMES],
   [FILTERS.NO_REPLY, FILTERS.REPLIED_MANY_TIMES],
+  [FILTERS.NO_USEFUL_REPLY_YET, FILTERS.HAS_USEFUL_REPLY],
 ];
 
 /**
@@ -69,6 +71,9 @@ export function getFilter(
       case FILTERS.NO_USEFUL_REPLY_YET:
         filterObj.hasArticleReplyWithMorePositiveFeedback = false;
         break;
+      case FILTERS.HAS_USEFUL_REPLY:
+        filterObj.hasArticleReplyWithMorePositiveFeedback = true;
+        break;
       case FILTERS.ASKED_ONCE:
         filterObj.replyRequestCount = { EQ: 1 };
         break;

diff --git a/constants/articleFilters.ts b/constants/articleFilters.ts
@@ -4,3 +4,4 @@ export const ASKED_MANY_TIMES = 'ASKED_MANY_TIMES';
 export const NO_REPLY = 'NO_REPLY';
 export const REPLIED_MANY_TIMES = 'REPLIED_MANY_TIMES';
 export const NO_USEFUL_REPLY_YET = 'NO_USEFUL_REPLY_YET';
+export const HAS_USEFUL_REPLY = 'HAS_USEFUL_REPLY';
diff --git a/i18n/zh_TW.po b/i18n/zh_TW.po
@@ -52,20 +52,20 @@ msgid "Sort by"
 msgstr "排序方式"
 
 #: components/ProfilePage/RepliedArticleTab.js:36
-#: pages/articles.js:173
-#: pages/replies.js:155
+#: pages/articles.js:143
+#: pages/replies.js:128
 msgid "Most recently asked"
 msgstr "最近被查詢"
 
 #: components/ProfilePage/RepliedArticleTab.js:33
-#: pages/articles.js:175
-#: pages/replies.js:154
+#: pages/articles.js:145
+#: pages/replies.js:127
 msgid "Most recently replied"
 msgstr "最近被回應"
 
 #: components/ProfilePage/RepliedArticleTab.js:37
-#: pages/articles.js:174
-#: pages/replies.js:156
+#: pages/articles.js:144
+#: pages/replies.js:129
 msgid "Most asked"
 msgstr "最多人詢問"
 
@@ -150,7 +150,7 @@ msgstr "已經送出回應。"
 msgid "Please login first."
 msgstr "請先登入。"
 
-#: pages/search.js:302
+#: pages/search.js:305
 msgid "Search"
 msgstr "搜尋"
 
@@ -323,7 +323,7 @@ msgstr "含有正確訊息"
 msgid "contains misinformation"
 msgstr "含有錯誤訊息"
 
-#: pages/replies.js:287
+#: pages/replies.js:260
 msgid "Bust Hoaxes"
 msgstr "查核闢謠"
 
@@ -333,26 +333,24 @@ msgstr "查核闢謠"
 msgid "Messages"
 msgstr "可疑訊息"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:23
-#: pages/search.js:316
+#: components/ListPageControls/ArticleStatusFilter.tsx:25
 msgid "Replied by me"
 msgstr "我查核過"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:22
+#: components/ListPageControls/ArticleStatusFilter.tsx:23
 msgid "No useful reply yet"
-msgstr "還未有有效查核"
+msgstr "尚無有效查核"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:19
+#: components/ListPageControls/ArticleStatusFilter.tsx:20
 msgid "Asked many times"
 msgstr "熱門回報"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:21
+#: components/ListPageControls/ArticleStatusFilter.tsx:22
 msgid "Replied many times"
 msgstr "多份查核"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:70
+#: components/ListPageControls/ArticleStatusFilter.tsx:118
 #: components/ListPageControls/Filters.js:70
-#: pages/search.js:314
 msgid "Filter"
 msgstr "篩選"
 
@@ -373,8 +371,8 @@ msgstr "查看更多"
 msgid "Hoax for you"
 msgstr "等你來答"
 
-#: pages/replies.js:238
-#: pages/replies.js:241
+#: pages/replies.js:211
+#: pages/replies.js:214
 msgid "Latest replies"
 msgstr "最新查核"
 
@@ -440,8 +438,8 @@ msgstr "在 可疑訊息"
 msgid "in Replies"
 msgstr "在 最新查核"
 
-#: pages/articles.js:162
-#: pages/articles.js:164
+#: pages/articles.js:132
+#: pages/articles.js:134
 msgid "Dubious Messages"
 msgstr "可疑訊息"
 
@@ -456,11 +454,11 @@ msgstr "您認為沒有幫助的理由是什麼呢？"
 #: components/LandingPage/SectionArticles.js:153
 #: components/ProfilePage/CommentTab.js:151
 #: components/ProfilePage/RepliedArticleTab.js:251
-#: pages/articles.js:188
+#: pages/articles.js:158
 #: pages/hoax-for-you.js:133
-#: pages/replies.js:258
-#: pages/search.js:181
-#: pages/search.js:258
+#: pages/replies.js:231
+#: pages/search.js:177
+#: pages/search.js:256
 msgid "Loading..."
 msgstr "載入中⋯"
 
@@ -714,7 +712,7 @@ msgstr "${ totalVisits } 次瀏覽"
 #: components/ListPageDisplays/ReplySearchItem.js:103
 #: components/ProfilePage/CommentTab.js:169
 #: components/ProfilePage/RepliedArticleTab.js:269
-#: pages/replies.js:268
+#: pages/replies.js:241
 #, javascript-format
 msgid "${ article.replyRequestCount } occurrence"
 msgid_plural "${ article.replyRequestCount } occurrences"
@@ -2311,7 +2309,7 @@ msgstr "目前已經存有4萬5千筆以上查證過的資訊，透過投入資
 #: components/ProfilePage/CommentTab.js:178
 #: components/ProfilePage/RepliedArticleTab.js:278
 #: pages/article/[id].js:385
-#: pages/replies.js:275
+#: pages/replies.js:248
 msgid "First reported ${ timeAgo }"
 msgstr "首次回報於 ${ timeAgo }"
 
@@ -2492,14 +2490,18 @@ msgstr ""
 msgid "Log in to view content"
 msgstr ""
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:18
+#: components/ListPageControls/ArticleStatusFilter.tsx:19
 msgid "Asked only once"
 msgstr "僅一人回報"
 
-#: components/ListPageControls/ArticleStatusFilter.tsx:20
+#: components/ListPageControls/ArticleStatusFilter.tsx:21
 msgid "Zero replies"
 msgstr "無人查核"
 
+#: components/ListPageControls/ArticleStatusFilter.tsx:24
+msgid "Has useful replies"
+msgstr "查核有效"
+
 #: pages/index.js:29
 msgctxt "site title"
 msgid "Cofacts"