Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feedbacks are not shown in reason popup when there are too many feedbacks #554

Open
MrOrz opened this issue Nov 21, 2023 · 2 comments · Fixed by #556
Open

New feedbacks are not shown in reason popup when there are too many feedbacks #554

MrOrz opened this issue Nov 21, 2023 · 2 comments · Fixed by #556

Comments

@MrOrz
Copy link
Member

MrOrz commented Nov 21, 2023

New feedbacks to this reply https://dev.cofacts.tw/reply/aaluiHkB9w1KR1Ikury_ is never shown, because it has already more than 100 feedbacks.

Currently we only load 100 feedbacks in the reasons display:
https://github.com/cofacts/rumors-site/blob/53690ec8e817f02a1b743b6aa28a274b68b93a1a/components/ArticleReplyFeedbackControl/ReasonsDisplay.js#L49C14-L49C17

This causes new feedbacks are not shown in the "See more" dialog. We should remove the limit.
Also, we should consider hiding feedbacks with no reasons.

@MrOrz MrOrz changed the title Loads all feedback when reason display is shown New feedbacks are not shown in reason popup when there are too many feedbacks Nov 21, 2023
@marcussfu
Copy link
Contributor

I'll do it

@MrOrz
Copy link
Member Author

MrOrz commented Feb 29, 2024

It seems that sorting is not working as expected.
Feedbacks with comments should come first, but still order by createdAt.

截圖 2024-02-29 下午8 17 29

@MrOrz MrOrz reopened this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants