#133: fixed the bug that the createdAt field of a reply is undefined #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...I forgot to update the snapshots orz |
changhc
force-pushed
the
133-reply-createdAt
branch
from
843a5c9
to
9c81fd9
Compare
MrOrz
reviewed
Aug 29, 2018
| }, | ||
| createdAt: '2017-11-15T08:08:08.782Z', |
There was a problem hiding this comment.
I particularly like this part when you added createdAt to both articleReply and reply to the fixture in order to capture the behavior that we selected articleReply's time to display. Very considerate. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #133.
Note that here I followed the design for CurrentReply and used the createdAt field of ReplyConnection, i.e. the time a reply is created under an article no matter it's a brand new reply or a quote.