Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize files and extract common components #289

Merged
merged 7 commits into from Jul 22, 2020
Merged

Reorganize files and extract common components #289

merged 7 commits into from Jul 22, 2020

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jul 12, 2020

This is about cleaning up and pave way to the ArticlePageLayout refactor PR (#288 ).

Although there are 30+ files changed, a majority of them are caused by moving files around.

Features

Refactor

  • Rename components/ListPage to components/ListPageControls
    • This is to differentiate from the controls (inputs) from display (output) components.
  • Move display component for list pages to components/ListPageDisplays
  • Remove ArticleItem dependency in article detail page (page/articles)
    • Article detail page does not directly use <ArticleItem>, thus we should not add its fragments
    • In article page loading fragment, we replaced ArticleItem's fragment with fields that is actually used.
  • Removes obsolete files
    • components/Modal: not used anymore, replaced by Material-UI dialogs
    • componnets/__snapshots__/TimeRange.stories.storyshot: obsolete snapshot that we forgot to delete previously

Screenshots

No visual change at all.

@MrOrz MrOrz self-assigned this Jul 12, 2020
@MrOrz MrOrz marked this pull request as ready for review July 12, 2020 19:12
@MrOrz MrOrz requested review from LucienLee and nonumpa and removed request for bil4444 July 12, 2020 19:13
Base automatically changed from makestyle-snapshot to dev July 22, 2020 04:57
@MrOrz MrOrz merged commit 4d53792 into dev Jul 22, 2020
@MrOrz MrOrz deleted the reorganize branch July 22, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant