Fix dev "cannot invoke map of undefined" bug #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArticleInfo should query for articleReplies as it is using articleReply data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArticleInfo should query for articleReplies as it is using articleReply data.
Before
Staging:
Localhost:
After
Detail page can load without problem
Analysis
<ArticleInfo>inArticleDetailpage actually usesarticleRepliesfield. However, It's not declared in its fragment, thusarticleRepliesfields are not populated properly in detail page.This PR adds the field in loading sequence so that the field exists no matter where
<ArticleInfo>is used.