Prevent search input from being hided #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
reviewed
Jul 25, 2020
| @@ -232,7 +232,7 @@ function AppHeader({ | |||
| <Links classes={classes} unsolvedCount={unsolvedCount} /> | |||
| </Box> | |||
| </div> | |||
| <GlobalSearch onIconClick={() => setDisplayLogo(false)} /> | |||
There was a problem hiding this comment.
Personally I would prefer onExpanded or onToggle because this is the scenario that a child component component notifies parent component about something happening. Parent component can determine how to react to such event.
<GlobalSearch onExpand={expanded => setDisplayLogo(!expanded)} />There was a problem hiding this comment.
I've refactor the relation between the parent and the child component so that parent listen to child's change rather then the child change the parent directly
MrOrz
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #280