Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new reply type "opinionated" and adjust "not article" wordings #31

Merged
merged 6 commits into from Aug 11, 2017

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 11, 2017

Fixes #22 , Fixes #28

In order to enable shared style ( see https://github.com/cofacts/rumors-site/pull/31/files#diff-a166c852270284265979a9e66e367d36R8 ), we have to disable prostcss-nested and remove the deprecated style-jsx-postcss.

Also rewords NOT_ARTICLE and add their suggestions
1. styled-jsx-postcss is no longer maintained.
2. styled-jsx/babel does not support nesting, so we drop all nesting css in the commit as well
@MrOrz MrOrz self-assigned this Aug 11, 2017
@MrOrz MrOrz merged commit 833b744 into master Aug 11, 2017
@MrOrz MrOrz deleted the features/opinionated-not-article branch August 11, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant