Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track rss, and add utm_source to each url that generated from feed.js #321

Merged
merged 5 commits into from Sep 16, 2020
Merged

Track rss, and add utm_source to each url that generated from feed.js #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44b3793
Track rss, and add utm_source to each url that generated from feed.js
nonumpa Sep 14, 2020
c39a788
Track rss subscriber number by sending res.header from fetcher
nonumpa Sep 14, 2020
df3962c
Fix copy feedUrl function, it shouldn't encode the url
nonumpa Sep 14, 2020
6bbe491
Rename [feed].js ga event action form `Subscribe` to `Poll`
nonumpa Sep 15, 2020
ab602ca
Remove redundant code
nonumpa Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions components/Subscribe/FeedDisplay.js
View file
Open in desktop
Expand Up @@ -81,8 +81,6 @@ function FeedDisplay({ listQueryVars }) {
handleClose();
};

const encodedFeedUrl = encodeURIComponent(feedUrl);

return (
<>
<Button onClick={handleClick} className={classes.button}>
Expand All @@ -105,7 +103,9 @@ function FeedDisplay({ listQueryVars }) {
<List>
<ListItemLink
email={true}
href={`https://feedrabbit.com/?url=${encodedFeedUrl}`}
href={`https://feedrabbit.com/?url=${encodeURIComponent(
feedUrl + `&source=Feedrabbit`
)}`}
icon={mailIcon}
onClick={handleClose}
>
Expand All @@ -119,7 +119,9 @@ function FeedDisplay({ listQueryVars }) {
></ListItemText>
</ListItemLink>
<ListItemLink
href={`https://feedly.com/i/discover/sources/search/feed/${encodedFeedUrl}`}
href={`https://feedly.com/i/discover/sources/search/feed/${encodeURIComponent(
feedUrl + `&source=Feedly`
)}`}
icon={feedlyIcon}
onClick={handleClose}
>
Expand All @@ -128,7 +130,7 @@ function FeedDisplay({ listQueryVars }) {

<ListItemCopy
icon={rssIcon}
textToCopy={feedUrl}
textToCopy={feedUrl + `&source=Others`}
onSuccess={() => copySuccess(t`Copied to clipboard!`)}
>
{t`Get RSS Feed Link`}
Expand All @@ -146,23 +148,23 @@ function FeedDisplay({ listQueryVars }) {
<IFTTTItem
icon={lineIcon}
IFTTTAppletUrl={PUBLIC_LINE_IFTTT_APPLET_URL}
feedUrl={feedUrl}
feedUrl={feedUrl + `&source=IFTTT_Line`}
tutorialYoutubeId={PUBLIC_LINE_IFTTT_TUTORIAL_YOUTUBEID}
>
{'Line'}
</IFTTTItem>
<IFTTTItem
icon={telegramIcon}
IFTTTAppletUrl={PUBLIC_TELEGRAM_IFTTT_APPLET_URL}
feedUrl={feedUrl}
feedUrl={feedUrl + `&source=IFTTT_Telegram`}
tutorialYoutubeId={PUBLIC_TELEGRAM_IFTTT_TUTORIAL_YOUTUBEID}
>
{'Telegram'}
</IFTTTItem>
<IFTTTItem
icon={slackIcon}
IFTTTAppletUrl={PUBLIC_SLACK_IFTTT_APPLET_URL}
feedUrl={feedUrl}
feedUrl={feedUrl + `&source=IFTTT_Slack`}
tutorialYoutubeId={PUBLIC_SLACK_IFTTT_TUTORIAL_YOUTUBEID}
>
{'Slack'}
Expand Down
60 changes: 59 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -48,7 +48,8 @@
"react-virtualized-auto-sizer": "^1.0.2",
"rollbar": "^2.14.4",
"stackimpact": "^1.3.23",
"ttag": "^1.7.22"
"ttag": "^1.7.22",
"universal-analytics": "^0.4.23"
},
"devDependencies": {
"@apollo/react-testing": "^3.0.1",
Expand Down
16 changes: 14 additions & 2 deletions pages/api/articles/[feed].js
View file
Open in desktop
Expand Up @@ -10,11 +10,12 @@ import { config } from 'lib/apollo';
import rollbar from 'lib/rollbar';
import { TYPE_NAME } from 'constants/replyType';
import JsonUrl from 'json-url';
import ua from 'universal-analytics';

const TITLE_LENGTH = 40;
const AVAILABLE_FEEDS = ['rss2', 'atom1', 'json1'];
const {
publicRuntimeConfig: { PUBLIC_URL },
publicRuntimeConfig: { PUBLIC_URL, PUBLIC_GA_TRACKING_ID },
} = getConfig();

// This should match article "time" fields in ListArticleOrderBy
Expand Down Expand Up @@ -152,7 +153,7 @@ async function articleFeedHandler(req, res) {
try {
data.ListArticles.edges.forEach(({ node }) => {
const text = getArticleText(node);
const url = `${PUBLIC_URL}/article/${node.id}`;
const url = `${PUBLIC_URL}/article/${node.id}?utm_source=${query.source}&utm_medium=RSS`;
const articleReply = node.articleReplies[0];
feedInstance.addItem({
id: url,
Expand Down Expand Up @@ -184,12 +185,23 @@ async function articleFeedHandler(req, res) {
});
});

const visitor = ua(PUBLIC_GA_TRACKING_ID);
const params = {
ec: 'RSS',
ea: 'Poll',
el: query.source,
dp: JSON.stringify(listQueryVars), // filter, document path: maxlength 2048 bytes
dt: JSON.stringify(req.headers), // some headers contain follower number, document title: maxlength 1500 bytes
};
visitor.event(params).send();

// https://stackoverflow.com/questions/595616/what-is-the-correct-mime-type-to-use-for-an-rss-feed
const type = accepts(req).type([
'application/rss+xml',
'application/xml',
'text/xml',
]);

res.setHeader('Content-Type', type || 'text/xml');
res.send(feedInstance[feed]());
} catch (e) {
Expand Down