Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barebone for reply list #33

Merged
merged 9 commits into from Aug 24, 2017
Merged

Barebone for reply list #33

merged 9 commits into from Aug 24, 2017

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 20, 2017

Related to #32.

Reply list

normal-reply-list


Mine-only reply list for logged-in people

mine-only


Implements

  • Barebone for reply list component
  • Reply list data-loading logic

Refactors

  • Article list and reply list both inherits from ListPage, which implements all change handlers for filter / sorting.
  • Move styles shared by Article list and reply list to index.styles.js
  • Refactor render functions in article list to match reply list's implementation
  • Remove connect on <Pagination /> so that it can be also used in reply list
  • Set / Read "isLoading" state for article list and reply list

@MrOrz MrOrz self-assigned this Aug 20, 2017
@MrOrz MrOrz merged commit 47f8585 into master Aug 24, 2017
@MrOrz MrOrz deleted the 32-reply-list branch February 7, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant