Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese version #432

Merged
merged 3 commits into from
May 5, 2021
Merged

Japanese version #432

merged 3 commits into from
May 5, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented May 2, 2021 •
edited
Loading

  • Include Japanese translation in codebase
  • Build & push script
  • Relax landing page style so that it also works for Japanese version

Deployed to: https://ja.cofacts.tw/

localhost_3000_

@MrOrz MrOrz requested review from hsiao19 and bil4444 May 2, 2021 16:15
@MrOrz MrOrz self-assigned this May 2, 2021
@MrOrz
Copy link
Member Author

MrOrz commented May 5, 2021

Seems that there are missing kanji font in our current font selection
image

@MrOrz MrOrz marked this pull request as ready for review May 5, 2021 06:00
@MrOrz MrOrz merged commit 3ae6359 into master May 5, 2021
@MrOrz MrOrz deleted the ja branch May 5, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@hsiao19 hsiao19 Awaiting requested review from hsiao19

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MrOrz @bil4444