Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SSG case #458

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Handle SSG case #458

merged 1 commit into from
Dec 4, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Dec 4, 2021

Previous image build fails due to the server-side cookie logic introduced in #457 .

This PR fixes the build by properly handle SSG case, which will have undefined ctx.req.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.363% when pulling 7ef839a on fix-build into 20c9b0b on master.

@MrOrz MrOrz self-assigned this Dec 4, 2021
@MrOrz
Copy link
Member Author

MrOrz commented Dec 4, 2021

Build pass & works on staging, will directly merge

@MrOrz MrOrz merged commit 7306375 into master Dec 4, 2021
@MrOrz MrOrz deleted the fix-build branch December 4, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants