Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppLayout][LandingPage] change forum links to tutorial #464

Merged
merged 3 commits into from Dec 12, 2021
Merged

[AppLayout][LandingPage] change forum links to tutorial #464

merged 3 commits into from Dec 12, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Dec 11, 2021 •
edited

Discussion: https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ

This PR replaces the original "Forum" link in app header & app sidebar to tutorial.

  • Landing page: "Forum" link changed to "Tutorial" and point to how-to-check-rumors tutorial (/tutorial?tab=check-rumors)
  • Inside application: "Forum link" in app header & sidebar changed to "Tutorial" pointing to fact-checking tutorial.
  • Add tutorial link to footer. (/tutorial)

Landing page

圖片

Inside application

Desktop header

圖片

Mobile sidebar

圖片

Footer

圖片

@MrOrz MrOrz self-assigned this Dec 11, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.363% when pulling 0c0aeba on tutorial-link into 0d67a1f on master.

nonumpa
nonumpa approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrOrz MrOrz merged commit e4f24b2 into master Dec 12, 2021
@MrOrz MrOrz deleted the tutorial-link branch December 12, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonumpa nonumpa nonumpa approved these changes

@hsiao19 hsiao19 Awaiting requested review from hsiao19

@bil4444 bil4444 Awaiting requested review from bil4444

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrOrz @coveralls @nonumpa