Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ActionMenu and refactor article replies #470

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jan 23, 2022

  • Extract ActionMenu (menu with vertical "⋯" button) from ReplyActions
  • Replace verbose props of ReplyAction to one single articleReply
    • Previously there is an insane prop drill of actionText, disabled & onAction props from CurrentReplies & reply/[id] all the way down to ReplyAction
    • However, all it needs to perform action is a article-reply instance.
    • Minor behavior change: after restoring a reply from "Deleted replies" dialog, the dialog will not close automatically if there are still other deleted replies. I think this behavior is OK for the users.
  • Remove unused props from components like ArticleReply, DeletedItems
    • They are not used in codebase at all......

ActionMenu

圖片

@coveralls
Copy link

coveralls commented Jan 23, 2022

Coverage Status

Coverage decreased (-0.06%) to 74.628% when pulling 4755649 on refactor-reply-action into d10987d on master.

@MrOrz MrOrz merged commit 8bbee3a into master Jan 25, 2022
@MrOrz MrOrz deleted the refactor-reply-action branch January 25, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants