Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add articleTypes URL param without UI #501

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Add articleTypes URL param without UI #501

merged 1 commit into from
Aug 24, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 24, 2022

This PR adds a URL param, articleTypes, to rumors-site article list.

  • Currently we do not officially launch image support, so the UI of this filter is not implemented yet.
    • Users must manually specify articleTypes in URL, it is not accessible from UI.
  • articleTypes should be a comma separated list of ArticleTypeEnum (TEXT, IMAGE, VIDEO, AUDIO).
  • When not given, articleTypes is not specified in ListArticles.
  • If given, articleTypes is specified and thus would override MEDIA_ARTICLE_SUPPORT flag in rumors-api.

Screenshot

Only images

image

Only text

image

Not specified

The result depends on if the API has turned on MEDIA_ARTICLE_SUPPORT flag. On staging it is turned on, so it does not limit the article type to just text.
image

@MrOrz MrOrz requested review from nonumpa and bil4444 August 24, 2022 05:32
@MrOrz MrOrz self-assigned this Aug 24, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.831% when pulling e013012 on article-type into 1808d09 on master.

@MrOrz MrOrz merged commit 32f1d6c into master Aug 24, 2022
@MrOrz MrOrz deleted the article-type branch August 24, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants