Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in Profile page #509

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Comments in Profile page #509

merged 7 commits into from
Oct 12, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 10, 2022 •
edited
Loading

This implements a comment list that lists out the user's comments, allowing user to come back and write replies.

  • Implements CommentTab by copy and modify from existing RepliedArticleTab
  • Add link from profile tabs to article detail page
  • Add "Comments" stat to profile page header

image

@MrOrz MrOrz changed the base branch from master to article-type-filter October 10, 2022 02:06
@coveralls
Copy link

coveralls commented Oct 10, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 76.249% when pulling 757035a on profile-comment into 07c3820 on article-type-filter.

@MrOrz MrOrz self-assigned this Oct 10, 2022
@MrOrz MrOrz marked this pull request as ready for review October 10, 2022 02:37
Base automatically changed from article-type-filter to master October 12, 2022 15:29
@MrOrz MrOrz merged commit b5c6830 into master Oct 12, 2022
@MrOrz MrOrz deleted the profile-comment branch October 13, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyy0216 andyy0216 andyy0216 approved these changes

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrOrz @coveralls @andyy0216 @bil4444