Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw error when article does not have ID #532

Merged
merged 1 commit into from Feb 26, 2023
Merged

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Feb 25, 2023

articleUserId is just used in reporting user, should not block page from rendering.

Fixes #531

Before: https://cofacts.tw/article/5673777689453-rumor
After: https://dev.cofacts.tw/article/5673777689453-rumor

- articleUserId is just used in reporting user, should not block page from rendering
@MrOrz MrOrz requested a review from nonumpa February 25, 2023 11:21
@MrOrz MrOrz self-assigned this Feb 25, 2023
@coveralls
Copy link

Coverage Status

Coverage: 76.412%. Remained the same when pulling 6c65885 on fix-null0user into 1244820 on master.

@MrOrz MrOrz merged commit 7044c6a into master Feb 26, 2023
@MrOrz
Copy link
Member Author

MrOrz commented Feb 26, 2023

Merge as hotfix

@MrOrz MrOrz deleted the fix-null0user branch February 26, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'id')
2 participants