Implement CollabEditor #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonumpa
force-pushed
the
feature/collab
branch
2 times, most recently
from
51795a7
to
9e7f19f
Compare
…ranscripts to database
MrOrz
reviewed
Jun 28, 2023
| }); | ||
|
|
||
| // TODO: listen textChanged event? | ||
| article.text = text; |
There was a problem hiding this comment.
Should probably try reloading article.text from GraphQL in this case
There was a problem hiding this comment.
Yes, but I am not sure if client can know when the article.text is updated. Maybe we can try HocuspocusProvider Events.
|
|
||
| // TODO: listen textChanged event? | ||
| article.text = text; | ||
| editorView.destroy(); |
There was a problem hiding this comment.
Question: do we need to do anything to ensure that changes are all synced to Hocuspocus before destroying the prosemirror instance here?
MrOrz
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text editor
prosemirror-schema-basic, we can write our own schema when need extra features)Backend
Screenshots
Before
Article list page
Article page
Editing
Article page
placeholder
online user
Done
Article list page
Article page