Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements of images in article page #542

Merged
merged 2 commits into from
Jul 11, 2023
Merged

UX improvements of images in article page #542

merged 2 commits into from
Jul 11, 2023

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Jul 9, 2023

Fix #540

  • change the order of text and image
  • add image right margin

Snapshots

Before

截圖 2023-07-09 下午3 07 08

After

截圖 2023-07-09 下午3 05 38

@nonumpa nonumpa requested a review from MrOrz July 9, 2023 07:09
@coveralls
Copy link

Coverage Status

coverage: 76.218%. remained the same when pulling 30b8a6c on fix/ux_image_article into d49aa7d on master.

MrOrz
MrOrz approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's ship it :shipit:

@MrOrz MrOrz merged commit 802dc59 into master Jul 11, 2023
4 checks passed
@MrOrz MrOrz deleted the fix/ux_image_article branch July 11, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX improvements of images in article page
3 participants
@nonumpa @coveralls @MrOrz