201712 mappings refactor #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
force-pushed
the
201712-mappings-refactor
branch
from
2d15885
to
ab6d364
Compare
|
staging API site is down (Now Found) -Update- |
|
@GoreStarry 其實我昨天晚上我更新完 API server 版本之後就 404，也是清掉 koa session 的 cookie 就好了。 應該是我 login 那裡邏輯出了問題 Orz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make necessary changes to make the UI compatible with API after 201712-mappings-refactor.
Since we are having low test coverage in this repository, I am doing minimal changes to support the new API.
Please refer to staging API site for the new API.
Future improvements should follow these steps:
Currently we are not plan to rename concepts/names like 'ReplyConnections' to new names (like "ArticleReplies") thoroughly from rumros-site codebase yet.
We will put that off until we have a new UI, then we will switch to the new name when we are doing UI revamp.