Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlinked References All Expand #6

Closed
cofinley opened this issue Feb 12, 2021 · 0 comments · Fixed by #19
Closed

Unlinked References All Expand #6

cofinley opened this issue Feb 12, 2021 · 0 comments · Fixed by #19
Labels
bug Something isn't working
Milestone
v1.0

Comments

@cofinley
Copy link
Owner

Clicking to show unlinked references on one page shows them on all
@cofinley cofinley added the bug Something isn't working label Feb 12, 2021
@cofinley cofinley mentioned this issue Feb 12, 2021
Closed
42 tasks
@cofinley cofinley added this to the v1.0 milestone Feb 12, 2021
cofinley added a commit that referenced this issue Feb 14, 2021
@cofinley
#6 Prevent toggling unlinked refs for all pages on click
00f0e41 
Unlinked refs were being toggled on every page after a single click on
one. This was because the <References> element in Editor.js was not
re-rendering as expected. It was sticking around and the hooks state
was shared among other pages' <References> elements. The calculation
of the unlinked references was only being done on page load, but it was
still unwelcome. Add key prop to differentiate the instances among pages.

Also fix bug where linked references were not showing because of a lapse
syncing code changes with redux.
@cofinley cofinley mentioned this issue Feb 14, 2021
Merged
cofinley added a commit that referenced this issue Feb 14, 2021
@cofinley
Merge pull request #19 from cofinley/bugfix/6-unlinked-references-all…
b824d30 
…-expand

#6 Prevent Toggling All Unlinked Refs on Click
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

#6 Prevent Toggling All Unlinked Refs on Click cofinley/free-roam
1 participant
@cofinley