#6 Prevent Toggling All Unlinked Refs on Click #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlinked refs were being toggled on every page after a single click on one. This was because the <References> element in Editor.js was not re-rendering as expected. It was sticking around and the hooks state was shared among other pages' <References> elements. The calculation of the unlinked references was only being done on page load, but it was still unwelcome. Add key prop to differentiate the instances among pages. Also fix bug where linked references were not showing because of a lapse syncing code changes with redux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlinked refs were being toggled on every page after a single click on
one. This was because the element in Editor.js was not
re-rendering as expected. It was sticking around and the hooks state
was shared among other pages' elements. The calculation
of the unlinked references was only being done on page load, but it was
still unwelcome. Add key prop to differentiate the instances among pages.
Also fix bug where linked references were not showing because of a lapse
syncing code changes with redux.
Closes #6