Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed non-ascii characters #34

Merged
merged 2 commits into from
Jul 29, 2014
Merged

Conversation

mengwong
Copy link
Contributor

jekyll refused to start. this was the easiest way for me to fix it

20140729-23:18:47 mengwong@venice:~/non-db-src/legal% bundle exec jekyll serve --watch
Configuration file: /Users/mengwong/non-db-src/legal/_config.yml
Source: .
Destination: /Users/mengwong/non-db-src/legal/_site
Generating... Liquid Exception: invalid byte sequence in US-ASCII in _includes/footers/legal.html, included in _layouts/default.html
error: invalid byte sequence in US-ASCII. Use --trace to view backtrace

…to barf

 20140729-23:10:41 mengwong@venice:~/non-db-src/legal% bundle exec jekyll serve --watch
 Configuration file: /Users/mengwong/non-db-src/legal/_config.yml
			 Source: .
		Destination: /Users/mengwong/non-db-src/legal/_site
	   Generating... Error reading file /Users/mengwong/non-db-src/legal/_posts/2013-12-01-purchase_agreement_for_convertible_note.html: invalid byte sequence in US-ASCII
   Liquid Exception: invalid byte sequence in US-ASCII in _includes/footers/legal.html, included in _layouts/default.html

 20140729-23:16:34 mengwong@venice:~/non-db-src/legal% for i in _posts/*.html; do perl -nle 'print "emacs +$.:".pos($_)." $ARGV;" if /[^[:ascii:]]/g' $i; done
20140729-23:20:14 mengwong@venice:~/non-db-src/legal% for i in **/*.html; do perl -nle 'print "emacs +$.:".pos($_)." $ARGV;" if /[^[:ascii:]]/g' $i; done
ksaitor added a commit that referenced this pull request Jul 29, 2014
removed non-ascii characters
@ksaitor ksaitor merged commit deba932 into cofounders:gh-pages Jul 29, 2014
@ksaitor
Copy link
Member

ksaitor commented Jul 29, 2014

👍 @mengwong

@sebdeckers
Copy link
Member

@ksaitor Why did you accept this PR without discussion? There is clearly an underlying issue with some dependency. I see this PR as an indication of an upstream problem. A rushed workaround is not needed. Also, restricting the content to merely ASCII is an unsustainable “solution.”

@ksaitor
Copy link
Member

ksaitor commented Jul 29, 2014

@CBas there was nothing in the diff that looked unacceptable.
At this stage, ease of use and contribution to this repo is critical.
Imho, more important than temporal restriction to ASCII.

@sebdeckers
Copy link
Member

@ksaitor 👍 Thanks for the supporting rationale. I agree and see no benefit in reverting the commit. Didn't mean to get all :neckbeard:.

Let's just make note of this as an issue. FWIW, I couldn't reproduce this on my machine.

@mengwong Thanks for the contribution and bug report. ❤️

@mengwong
Copy link
Contributor Author

the cause of the problem was spurious unicode lying around that looked like an artefact leftover from the original document.

Probably caused by my upgrade to Mavericks. I could just setenv but is that more of a workaround?

jekyll/jekyll#188

@sebdeckers
Copy link
Member

@mengwong AFAIK the files were correctly encoded as UTF-8. I intentionally sprinkled some Unicode quotes in the content for stylistic reasons and as a test to check if we can handle, for example, Chinese text.

Try adding this to Jekyll's _config.yml:

encoding: utf-8

Any difference then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants