DOC: Add docstring examples for app.sample.omit_gap_pos #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In app.sample.omit_degenerates and app.sample.omit_gap.pos
Pull Request Test Coverage Report for Build 7619243298Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
In app.sample.omit_degenerates and app.sample.omit_gap_pos. Fix type hinting for arguments where the default is None.
For test coverage.
khiron
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Thanks for the PR
Read over this with Gavin. Grammar stuff mainly. Funny story: every second comment I made about adding a trailing period, Gav picked me up for not adding a trailing period in my comment :)
Changed example to using a biological motivation wrt motif_length
Replace motif_length example with a biological one. Add trailing full stops.
khiron
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1636