Allow clip-box to auto expand #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @abarciauskas-bgse 🙏 Could you add a tests for this? Thanks 😄 |
|
Added tests: feb1936 let me know what you think @vincentsarago |
…kas-bgse/rio-tiler into ab/allow-rioxarray-auto-expand
|
@abarciauskas-bgse thanks for the test 🙏 About the fail CI, this is because we use see: https://github.com/cogeotiff/rio-tiler/blob/dev/CONTRIBUTING.md#pre-commit I think I'm all good from here. I'll backport this PR to the |
|
Working through the linting errors now! |
|
🙏 do not worry about the |
|
@abarciauskas-bgse I'm still wondering if we should just set the setting to True by default! If setting it to |
|
@vincentsarago 👍🏽 I have updated the default to |
vincentsarago
added a commit
that referenced
this pull request
Jun 1, 2023
* update readme * PER_BAND mask and MaskedArray (#580) * sketch use of MaskedArray with PER_BAND mask * update PointData and fix tests * update mosaics * update nodata mask * remove unused * update changelog * migration guide * split resampling option to RasterIO and Warp options (#590) * refactor Mask tests and Benchmark * refactor Mask tests and Benchmark (#591) * change arguments in dynamic_tiler.md (#592) * change arguments The argument ("tile", {"z": "{z}", "x": "{x}", "y": "{y}"}) causes errors below. File "/home/ubuntu/app/app.py", line 48, in tilejson tile_url = request.url_for("tile", {"z": "{z}", "x": "{x}", "y": "{y}"}) TypeError: HTTPConnection.url_for() takes 2 positional arguments but 3 were given ("tile", z='{z}', x='{x}', y='{y}') is correct. * Update docs/src/advanced/dynamic_tiler.md --------- Co-authored-by: Vincent Sarago <vincent.sarago@gmail.com> * refactor MosaicMethods (#594) * refactor MosaicMethods * fix tests * Optional boto3 (#597) * make boto3 an optional dependency * update migration * update test dependencies * add flake8 rules in ruff (#600) * update dev version * update mosaic example notebook custom pixel_selection class (#602) * improve cutline handling (#598) * Improve cutline handling Closes #588 * handle projection --------- Co-authored-by: vincentsarago <vincent.sarago@gmail.com> * remove useless cache * save benchmarks * add benchmarking in docs * fix nodata/mask/alpha forwarding for GCPS dataset (#604) * remove boto3 * Allow clip-box to auto expand (#608) * Allow clip-box to auto expand * Add test * Update tests/test_io_xarray.py * Fix import order * Changes from black linter * Change default to true * use auto_expand in part and update changelog --------- Co-authored-by: Vincent Sarago <vincent.sarago@gmail.com> * allow morecantile 4.0 (#606) * allow morecantile 4.0 * set morecantile min version to 4.0 * update changelog * forward statistics from STAC raster:bands (#611) * forward statistics from STAC raster:bands * forward tags as metadata and forward metadata when creating ImageData from list * update changelog * handle nodata in XarrayReader (#612) * handle nodata in XarrayReader * update changelog * add AWS credential overrides for S3 stac (#613) * add AWS credential overrides for S3 stac * catch warnings * deprecated model methods (#615) * update readme --------- Co-authored-by: TTY6335 <36815385+TTY6335@users.noreply.github.com> Co-authored-by: Daniel Wiesmann <yellowcap@users.noreply.github.com> Co-authored-by: Aimee Barciauskas <aimee@developmentseed.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #607