Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for pack-config-volume-mount includes #1

Closed
wants to merge 14 commits into from
Closed

Fix for pack-config-volume-mount includes #1

wants to merge 14 commits into from

Conversation

ericreeves
Copy link

Without this fix, Helm3 was spitting out invalid YAML that looked like this:

        - name: st2-packs-vol
          mountPath: /opt/stackstorm/packs
        - name: st2-virtualenvs-vol
          mountPath: /opt/stackstorm/virtualenvs        - name: st2-pack-configs-vol
          mountPath: /opt/stackstorm/configs/

cognifloyd and others added 14 commits June 17, 2021 12:21
@cognifloyd
add st2.packs.volumes section to volumes.yaml
7c717ad
@cognifloyd
consolidate packs-volume-mounts into templates
d6467c6
@cognifloyd
add st2.packs.volumes definitions to packs-volumes templates
5e23259
@cognifloyd
consolidate pack-configs-volume into templates
fffb488
@cognifloyd
add pack-configs-volume to more pods when st2.packs.volumes.enabled
b86feb5
@cognifloyd
add error messages if st2.packs.volumes config is incomplete
19f60bb
@cognifloyd
When st2.packs.volumes.enabled, make register-content packs-initConta…
1e1ff8e 
…iner include system packs
@cognifloyd
disable packs.configs ConfigMap if it is not needed/used
83cf9e7
@cognifloyd
add instructions for st2.packs.volumes values
64e1f2d
@cognifloyd
add st2.packs.volumes caveats similar to those documented in StackSto…
0d1c836 
…rm#118
@cognifloyd
README typo fixes
32eabce
@cognifloyd
add changelog entry
d7644d1
@cognifloyd
drop unnecessary "if and"
d9aa914
@eric-al
Fix for pack-config-volume-mount includes
2b43162
@cognifloyd cognifloyd mentioned this pull request Jun 20, 2021
Merged
@cognifloyd
Copy link
Owner

Thanks. Cherry-picked your changes.

@cognifloyd cognifloyd closed this Jun 20, 2021
cognifloyd pushed a commit that referenced this pull request Jun 2, 2022
@cwilson21
Merge pull request #1 from cwilson21/testing
250bbec 
Adding override config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ericreeves @cognifloyd @eric-al