Do not load go_dependencies() in bzlmod extension #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenmj
force-pushed
the
mortenmj-patch-3
branch
from
2e8ff39
to
91e409d
Compare
mortenmj
changed the title
mortenmj
force-pushed
the
mortenmj-patch-3
branch
from
91e409d
to
2376b18
Compare
psalaberria002
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All direct dependencies are already loaded through go.mod in MODULE.bazel. As such it is not needed, or desired, to also load the legacy go_dependencies() macro in our bzlmod extension. Furthermore, doing so causes errors for consumers of this module in some situations.